Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove popper shadow placed at theme level #3161

Merged
merged 1 commit into from
May 17, 2024
Merged

fix: Remove popper shadow placed at theme level #3161

merged 1 commit into from
May 17, 2024

Conversation

ianjon3s
Copy link
Contributor

What does this PR do?

Removes a visual regression introduced by placing popper shadow property at theme level.

Preview of issue:
image

@ianjon3s ianjon3s requested a review from a team May 17, 2024 11:13
DafyddLlyr
DafyddLlyr approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally just spotted this, think it sneaked back in via a rebase somewhere. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@ianjon3s ianjon3s merged commit 31f6072 into main May 17, 2024
12 checks passed
@ianjon3s ianjon3s deleted the ian/remove-popper-shadow branch May 17, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

@jessicamcinchak jessicamcinchak jessicamcinchak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianjon3s @jessicamcinchak @DafyddLlyr